🤑 GitHub - learn-co-students/simple-blackjack-cli

Most Liked Casino Bonuses in the last 7 days 🔥

Filter:

Active

Free bonus

Sort:

Newest

Popular

SeGor SeGor 53 3 3 bronze badges. Featured on Meta. Apart from those two points, I think your code is great. Should I use it elsewhere? Related 4. The point is : When naming a class, ask yourself what that class represents and name it this way. Hot Network Questions.

Code Review Stack Exchange is a question and answer site for peer programmer code reviews. Firstly, these variable names could use a little love, naming them cards, probabilities and money would be useful, but I'd go one step farther and try simple blackjack cli find better class names for those three classes.

It also shows probabilities of simple blackjack cli dealer's hidden card rather $2 blackjack reno have a blackjack no need for bust probability for dealer because you can't bust on just 2 cards.

Active Oldest Votes. There are three classes used as a way to store variables that I want to access throughout the program.

Or if I should use more classes Is this the correct usage? This is a simple CLI Blackjack game in python3. This shows probabilities of bust or blackjack if the user takes another hit. Sign up using Facebook.

The best answers are voted up and rise to the top. I saw that there were others already posted here and tried to implement some of their solutions and logic where I understood it.

Second of all, I think you should either encapsulate this code in a class where c,p,m would be member variables self. What posts should be simple blackjack cli to staff using [status-review], and how do I…. My game is a little simple blackjack cli in that I have a "probability mode".

In my opinion this makes for more easily understandable code, but I'm not very experienced so I don't know if this is best practices. Active 9 months ago. The main problem with your code is that your methods are using the global variables c,p,m.

Question feed.

This avoids having to pass in arguments all the time. The Overflow Blog. Podcast JavaScript is ready to get its own place. It only takes a minute to sign up. Email Required, but never shown. We're switching to CommonMark. Sign up or log in Sign up using Google. Otherwise, it makes the code difficult to understand. Sign up using Email and Password. Let's update the modal for new askers. Asked 1 year, 1 month ago. Phrancis: A final review of a good member. Home Questions Tags Users Unanswered. I'd expect a class Cards to represent a pack of cards, not the hands of two different players. Otherwise, you have methods that can't be called before the three global variables have been initialized and while this works in your current situation, if you were to move your code a little bit it might break, which is a pretty big code smell. Viewed 93 times. Sign up to join this community. Post as a guest Name.